search

markshust / magento2-module-disabletwofactorauth

The DisableTwoFactorAuth module provides the ability to disable two-factor authentication.
MIT License
194 stars 39 forks source link

Update module.xml #2

Closed jissereitsma closed 3 years ago

jissereitsma commented 3 years ago

Thanks for creating this module. One could argue that the admin settings suggest that the backend module is needed as well. It is not strictly so, because your module works without it. But anyway, feel free to merge this ... or not :)

markshust commented 3 years ago

Hi @jissereitsma. Thanks! I will indeed decline this PR, because 1) there are no direct calls to classes in the Backend module, and 2) the Magento_TwoFactorAuth module depends on Magento_User, which in turn depends on Magento_Backend. I'd say less code is better than adding code which isn't needed.

jissereitsma commented 3 years ago

No worries