search

markshust / magento2-module-disabletwofactorauth

The DisableTwoFactorAuth module provides the ability to disable two-factor authentication.
MIT License
199 stars 41 forks source link

Update composer php version to 7.4. #8

Closed Rud5G closed 3 years ago

Rud5G commented 3 years ago

Class typed properties require PHP7.4

see https://github.com/markshust/magento2-module-disabletwofactorauth/blob/635bbfe89c6b4d8cc3dfe1a3e1c92072b801433a/Plugin/BypassTwoFactorAuth.php#L18

markshust commented 3 years ago

@Rud5G thank you, I wasn't thinking when I made this update.

I'd actually like to support PHP 7.3 as well, so I think it's better to remove the typed properties instead.

markshust commented 3 years ago

Fixed in https://github.com/markshust/magento2-module-disabletwofactorauth/issues/6

Rud5G commented 3 years ago

Thanks for the quick reply, love your work.