#3 fix grid display and filters

markshust / magento2-module-ordergrid

The Order Grid module adds more details to the order grid in the admin.

MIT License

85 stars 30 forks source link

#3 fix grid display and filters #4

Closed paugnu closed 3 years ago

paugnu commented 4 years ago

Hi @markshust,

The following PR fixes 2 issues I've found in Magento 2.4 (one of them mentioned in issue number #3 )

Order grid styles are incorrect (I've found that it was due to the filter container in the sales_order_grid.xml file)
Filters wouldn't work

The addFieldToFilter function had some «incoherences» (looking for a 'products' field when it was actually 'order_items'). Maybe the solution I've implemented is not the best one, but now it works fine.

I'll let you test and confirm it's ok :)

markshust commented 4 years ago

Thanks @paugnu! I'll test this out in just a bit and let you know.

paugnu commented 4 years ago

Hey @markshust :) Not trying to push you :P, but just in case you forgot about this PR :)

arisdhiamandi commented 3 years ago

Hi, I made the changes but still some issues persist:

You cant Apply filters If you select one item automatically selects all The pager doesn't work It gives only 1 record found And the search doesn't work correctly Btw i am using Magento 2.4.

Other than that great work.

Thank you

markshust commented 3 years ago

@paugnu I have no clue why this was never merged in, apologize for this. I'll merge and re-tag.