change return type of apply function

markshust / magento2-module-simpledata

The SimpleData module simplifies calling Magento data structures.

MIT License

94 stars 7 forks source link

change return type of apply function #6

Closed torhoehn closed 3 years ago

torhoehn commented 3 years ago

Change return type to match PatchInterface

Return type (void) of method
SomeDataPatch.php::app
ly() should be compatible with return type
($this(Magento\Framework\Setup\Patch\PatchInterface)) of method
Magento\Framework\Setup\Patch\PatchInterface::apply()

torhoehn commented 3 years ago

@markshust Any update on this?

markshust commented 3 years ago

@torhoehn sorry I got really behind with PRs for all my projects, just getting back up to speed. I'll merge this in 👍

torhoehn commented 2 years ago

@markshust Could you please release a new tag so I can use this change as real version?

markshust commented 2 years ago

@torhoehn oh yea sorry about that! 🤪

All pushed out & tagged as 2.0.2.

torhoehn commented 2 years ago

@markshust Thanks a lot!