search

markshust / module-foobar

This repository contains code examples of Magento 2 modules.
5 stars 1 forks source link

Corresponding Article needs update for block class #2

Open jkusachi opened 7 years ago

jkusachi commented 7 years ago

Hello, there is a slight typo in your article (github is OK) regarding the block class. It isn't namespaced.

Article: https://mageinferno.com/blog/how-create-template-block-magento-2

In the article you have:

<referenceContainer name="main">
      <block class="FooBarBlockBaz" template="default/baz.phtml"/>
</referenceContainer>
<referenceContainer name="content">
    <block class="Foo\Bar\Block\Baz" template="Foo_Bar::default/baz.phtml"/>
</referenceContainer>

The template should work just fine, but I don't think the class will. Just a heads up for any of your readers (myself included)

Thanks.

markshust commented 7 years ago

Thanks for the info James, I'll update this shortly! Mark

On Wed, Jan 18, 2017 at 11:46 AM James Kusachi notifications@github.com wrote:

Hello, there is a slight typo in your article (github is OK) regarding the block class. It isn't namespaced.

Article: https://mageinferno.com/blog/how-create-template-block-magento-2

In the article you have:

The template should work just fine, but I don't think the class will. Just a heads up for any of your readers (myself included)

Thanks.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mageinferno/module-foobar/issues/2, or mute the thread https://github.com/notifications/unsubscribe-auth/AAarJQImPWR-iINLNWw0oSI4DUyaRyfgks5rTkHJgaJpZM4LnHZA .

markshust commented 7 years ago

All updated. This is an old article that needs an update, but I did fix those two spots. Thanks again

Mark

On Thu, Jan 19, 2017 at 10:02 AM Mark Shust mark@shust.com wrote:

Thanks for the info James, I'll update this shortly! Mark

On Wed, Jan 18, 2017 at 11:46 AM James Kusachi notifications@github.com wrote:

Hello, there is a slight typo in your article (github is OK) regarding the block class. It isn't namespaced.

Article: https://mageinferno.com/blog/how-create-template-block-magento-2

In the article you have:

The template should work just fine, but I don't think the class will. Just a heads up for any of your readers (myself included)

Thanks.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mageinferno/module-foobar/issues/2, or mute the thread https://github.com/notifications/unsubscribe-auth/AAarJQImPWR-iINLNWw0oSI4DUyaRyfgks5rTkHJgaJpZM4LnHZA .