search

markstory / mini-asset

A simple set of asset build tools that provides a config file and extensible integrations with pre-processors & minifiers.
MIT License
64 stars 17 forks source link

add filter for CleanCss #69

Closed mrothauer closed 2 years ago

mrothauer commented 2 years ago

new filter for https://github.com/clean-css/clean-css feel free to adapt the code if you want

mrothauer commented 2 years ago

how would I test my filter? it needs cleancss (node module) installed. I wanted to see how it's done by another node filter (uglifyjs) - but there is no test. should I create a package.json in tests/test_files? or should I mock it? if so, please tell me how you want it to be implemented

markstory commented 2 years ago

I wanted to see how it's done by another node filter (uglifyjs) - but there is no test. should I create a package.json in tests/test_files?

Aw poop, I thought I added tests for the existing node filters, but it looks like I never did do that. Don't worry about the test for now, I'll add one when I get around to doing the others.

mrothauer commented 2 years ago

Hi @markstory, when can I expect a new release with my contribution?

markstory commented 2 years ago

I think we'd need to skip the new tests as I don't want to leave master in a broken state.