Closed mrothauer closed 7 months ago
Hi Mark, I updated my app to CakePHP 5 and realized, that my commits for the CleanCss filter are not yet merged to the 2.x branch. Could you do that please?
https://github.com/markstory/mini-asset/compare/2.x...master
Minor adaptions for the filter are required (argument types and return types), here you find the adapted file which is working: https://github.com/foodcoopshop/foodcoopshop/blob/issue-917-cakephp-5-update/config/mini-asset/CleanCss.php
I can do the PR if you want as soon as you merge the commits into the branch.
Thank you, Mario
Released 2.1.0
markstory
commented
7 months ago
Hi Mark, I updated my app to CakePHP 5 and realized, that my commits for the CleanCss filter are not yet merged to the 2.x branch. Could you do that please?
https://github.com/markstory/mini-asset/compare/2.x...master
Minor adaptions for the filter are required (argument types and return types), here you find the adapted file which is working: https://github.com/foodcoopshop/foodcoopshop/blob/issue-917-cakephp-5-update/config/mini-asset/CleanCss.php
I can do the PR if you want as soon as you merge the commits into the branch.
Thank you, Mario