add contextual open around requirements.txt read in setup.py

markstory / sphinxcontrib-phpdomain

A PHP domain for sphinx. Allows you to annotate PHP objects in your sphinx docs.

Other

19 stars 14 forks source link

Closed ViktorHaag closed 7 years ago

ViktorHaag commented 7 years ago

This approach has several benefits:

closes the opened file explicitly
doesn't use an OS-dependent file separator to find requirements.txt
doesn't make assumptions about curdir during the installation process via pip (which worked as-is under a Py2 environment, but choked under a Py3 environment)

ViktorHaag commented 7 years ago

Addresses issue #10

ViktorHaag commented 7 years ago

Thanks for the speedy turnaround!

markstory commented 7 years ago

New tag (0.2.4) is on pypi.