search

markstory / sphinxcontrib-phpdomain

A PHP domain for sphinx. Allows you to annotate PHP objects in your sphinx docs.
Other
19 stars 15 forks source link

Fix references resolving #60

Closed mvorisek closed 1 year ago

mvorisek commented 1 year ago

fix part of #56 - fixes absolute references (but declarations still cannot currently contain \)

also fix #58

also missing targets are newly reported, as infos only, as some targets might be in other projects, global PHP classes, ... and CI must pass

also the testing is unified and the html output for all original tests is asserted using CI

also the code is reformatted, in separate commit, using Black to enforce strict coding style

output of all rst test files is exactly the same as before this PR -> no BC break

mvorisek commented 1 year ago

@markstory sorry for a lot of noise :), but I had to fix a lot of small issues in order to pass all the added tests. This PR is finally done, more to come in other PRs.

markstory commented 1 year ago

This is a big change, it might take me a few days to get through it.

mvorisek commented 1 year ago

@markstory the changes are not smaller, but the most of the changed LoC are changes from generated expected html and changes due Black CS. If you want the the Black CS changes as separate PR, let me know, but as I see you merge PRs using merge, thus the individual commits will be preserved even if merged as one PR.

markstory commented 1 year ago

I had to turn off tests for python 3.9+ as they started failing. I've also turned off the cron schedule for CI as it has been failing for a few days, likely due to a change in sphinx.