search

markstory / sphinxcontrib-phpdomain

A PHP domain for sphinx. Allows you to annotate PHP objects in your sphinx docs.
Other
19 stars 15 forks source link

Run full test diff for the latest CI Python version only #65

Open mvorisek opened 1 year ago

mvorisek commented 1 year ago

@markstory thank you for merging #60

fixes https://github.com/markstory/sphinxcontrib-phpdomain/pull/60#issuecomment-1683219323

latest Python version should be always fully tested

as older Sphinx deps might imply different than expected output, older Python versions are tested like before #60, ie. for build to pass only

I have also reenabled cron, cron is good to monitor the tests on continuous basis and thanks to GH it is visible for everyone, even for non-contributors, and is free.

mvorisek commented 1 year ago

@markstory can this CI fix PR be merged?

markstory commented 1 year ago

I have also reenabled cron, cron is good to monitor the tests on continuous basis and thanks to GH it is visible for everyone, even for non-contributors, and is free.

It isn't free though. It consumes resources (energy and time) and needlessly wastes those resources.

mvorisek commented 10 months ago

@markstory PR feedback is addressed, is there anything else to do?

mvorisek commented 9 months ago

Hi @markstory, this PR is here for a while and all the feedback should be addressed, may I ask you to merge it?

mvorisek commented 4 months ago

@markstory, can you please review?