marksweb / django-bleach

Bleach is a Python module that takes any HTML input, and returns valid, sanitised HTML that contains only an allowed subset of HTML tags, attributes and styles. django-bleach is a Django app that makes using bleach extremely easy.

MIT License

148 stars 23 forks source link

Include testproject in sdist #39

Closed debdolph closed 3 years ago

debdolph commented 3 years ago

Needed for debian packaging

marksweb commented 3 years ago

@debdolph I must be missing something here, why would you want the test project?

debdolph commented 3 years ago

Because the testproject is needed to run the test suite.

marksweb commented 3 years ago

@debdolph thats true, but if you've installed the packaged app, you don't need to run the test suite.

Tests are for development of the app so they're just included in the repo for work on the app & by the CI.

debdolph commented 3 years ago

Thats also true. But i want to run the test suite while building the debian package. Without the testsuite i can not guarantee that everything will work after building the package…

marksweb commented 3 years ago

@debdolph Ok this sounds interesting, but not something I've done before. Is this something that the project can build & publish just like the pypi package?

debdolph commented 3 years ago

The built package will be uploaded to the debian main repository so it has to be uploaded by a debian developer. (in other words: it cannot be build and published like the pypi package)

To build the package, i will download the source tarball and build the package from source. If the testproject is not included in the source tarball, i have to disable the testsuite in the build script and have to verify the functionality manually.

codecov[bot] commented 3 years ago

Codecov Report

Merging #39 (8f7b553) into master (232da00) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #39   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           87        87           
  Branches        17        17           
=========================================
  Hits            87        87

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 232da00...8f7b553. Read the comment docs.

marksweb commented 3 years ago

Alright, thanks @debdolph - I've merged.