Metadata cleanup - Githubissues

marksweston / finance

A library for financial calculations in Ruby

https://rubygems.org/gems/finance

Other

217 stars 93 forks source link

Metadata cleanup #15

Closed ghost closed 11 years ago

ghost commented 11 years ago

This commit:

Adds a Gemfile so that Bundler can be used to install dependencies.
Puts Gemfile.lock in .gitignore to keep that file out of source control.
Specifies Shoulda as a development dependency in the gemspec file (it's already being used in the test code).
Converts tabs to spaces in the gemspec file.

wkranec commented 11 years ago

I'm somewhat new to Bundler, but I think Gemfile.lock ought to be in the repository. At least, it is in the example on the main Bundler page: http://gembundler.com/.

ghost commented 11 years ago

When it comes to an application, yes, your repository should include Gemfile.lock. But a gem repository should not include Gemfile.lock. Yehuda (one of the Bundler authors) explains it better than I could:

http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/