markt-de / puppet-acme

Centralized SSL certificate management using acme.sh and the ACME protocol
https://forge.puppet.com/markt/acme
Apache License 2.0
9 stars 17 forks source link

deprecated option for acme.sh #32

Closed ashish1099 closed 4 years ago

ashish1099 commented 4 years ago

Currently module has these options --fullchainpath but master acme.sh has --fullchain-file.

so is it on purpose that we it depends on older version of acme.sh ?

https://github.com/acmesh-official/acme.sh/commit/5c539af7d7645723b928389bc93da526f0dcfa60

fraenki commented 4 years ago

so is it on purpose that we it depends on older version of acme.sh ?

The module does not depend on an old version. These deprecated options work perfectly fine even with the current devel version of acme.sh. I'd assume they will be removed in acme.sh 3.0.0.

However, thanks for bringing this to my attention, I will replace the deprecated options in the next release.