search

markt-de / puppet-acme

Centralized SSL certificate management using acme.sh and the ACME protocol
https://forge.puppet.com/markt/acme
Apache License 2.0
9 stars 17 forks source link

[ Bug / Suggestion ] default_ca should also be used for acme::certificate #37

Closed c33s closed 4 months ago

c33s commented 2 years ago

acme::certificate requires the definition of the ca but should also use the default ca if not provided

fraenki commented 2 years ago

What would be the benefit, could you provide a example config to demonstrate how this would be an improvement?

c33s commented 2 years ago

i just used acme::certificate and wondered why it fails as i had not defined the ca. i would assume that if i have defined a default_ca everywhere where i can provide a ca that it is optional and if it is not provided the default is taken

related to #38. i provided a usecase in my comment there https://github.com/fraenki/puppet-acme/issues/38#issuecomment-1009952253

fraenki commented 4 months ago

Implemented in https://github.com/markt-de/puppet-acme/commit/90cef4e88583ed305044cbeecb3f11d8f5ae6967.