markt-de / puppet-acme

Centralized SSL certificate management using acme.sh and the ACME protocol
https://forge.puppet.com/markt/acme
Apache License 2.0
9 stars 17 forks source link

Error while evaluating a Function Call, 'versioncmp' parameter 'a' expects a String value, got Undef #45

Closed advorkin closed 1 year ago

advorkin commented 1 year ago

Hello,

I'm getting the following error message:

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Function Call, 'versioncmp' parameter 'a' expects a String value, got Undef (file: /etc/puppetlabs/code/environments/puppet7/modules/acme/manifests/request/handler.pp, line: 185, column: 18

The line: $old_openssl = versioncmp($facts['openssl_version'], '1.1.0') < 0 Debug mode:

Debug: Facter: Executing command: /usr/bin/openssl version 2>&1
Debug: Facter: value for openssl_version is still nil
# /usr/bin/openssl version 2>&1
OpenSSL 1.1.1k  FIPS 25 Mar 2021
├─┬ fraenki-acme (v4.0.0)
│ ├── puppetlabs-stdlib (v8.5.0)
│ ├── puppetlabs-concat (v7.3.0)
│ ├── puppetlabs-vcsrepo (v5.4.0)
│ ├── puppetlabs-augeas_core (v1.2.0)
│ └── puppet-openssl (v2.0.1)

Puppet server - 7.11.0 Puppet agent - 7.24.0 RHEL 8 based OS.

I've already reviewed https://github.com/fraenki/puppet-acme/issues/27, but not seeing a clear solution.

Thank you.

advorkin commented 1 year ago

Please hold off working on this bug just yet. It could be something on our side, and I'm checking. Thank you.

advorkin commented 1 year ago

The following fix worked in Puppetfile:

mod 'puppet-openssl',
  :git    =>  'https://github.com/voxpupuli/puppet-openssl',
  :commit =>  '355004d'

https://github.com/voxpupuli/puppet-openssl/pull/135

fraenki commented 1 year ago

Thanks for putting this together. Unfortunately, there's still no new release of voxpupuli/puppet-openssl which includes this fix, hence I can't update the dependency accordingly.

However, I'll close this issue, because there's nothing we can do about it. I'll monitor voxpupuli/puppet-openssl releases for the time being.