search

markt-de / puppet-acme

Centralized SSL certificate management using acme.sh and the ACME protocol
https://forge.puppet.com/markt/acme
Apache License 2.0
9 stars 17 forks source link

secret leakage - Puppetboard #49

Closed DennisPohlmann closed 4 months ago

DennisPohlmann commented 5 months ago

Hey,

we use Puppetboard for our environments. We have some secrets leakage here: bug bug2

Can we remove this notice?: https://github.com/markt-de/puppet-acme/blob/13b1f41288338ab27004578164f36e6c30c56f0a/manifests/request.pp#L132

DennisPohlmann commented 5 months ago

Also https://github.com/markt-de/puppet-acme/blob/13b1f41288338ab27004578164f36e6c30c56f0a/manifests/request.pp#L214 should be removed. Or can this be disabled somehow?

fraenki commented 5 months ago

Sure, no objections, let's remove it. Would you submit a PR? It was only ever meant as a status message for debug purposes.

DennisPohlmann commented 5 months ago

@fraenki Thanks for the update. Will create a PR, otherwise it works like a charm. Thanks for your work.