Open VendettaMike opened 2 months ago
I should follow this up in that I think the facts should be coming from the node agent, and not the master. In the above code, both the node and the master will generate facts for the certificates, so there will be duplicates, but then administrators can use this information to check on node certificate status and compare to what the master has.
In my instance, I've also added additional facts such as issue and expiry date, and issuer information so that reports can be easily generated to ensure renewals and distribution are occurring, and with the right provider for each node.
I was reviewing facts on my Puppet server and noticed that only the _acmecsrs fact was included, no _acmecerts facts. I looked into the _/lib/facter/acmecert.rb code and saw the following:
This looks like it is trying to collect facts from the results directory which is only present on the Puppetserver. On the Puppet node, in my configuration, everything is stored in the certs folder. Changing to the following resulted in the _acmecerts facts being created:
Is this a bug or is it just my configuration?