search

markt-de / puppet-sonarqube

Puppet module for Sonarqube
Apache License 2.0
1 stars 20 forks source link

Systemd service file PIDFile mismatch #23

Closed storm49152 closed 2 years ago

storm49152 commented 2 years ago

Hi,

I came from the maestrodev/sonarqube module, and I'm currently using SonarQube 8.5.1. I know it's old, and I'm looking to upgrade to LTS first, then latest. But since the maestrodev module isn't maintained anymore, I thought I first upgrade to this module.

When I changed to using this module and keeping the 8.5.1 version, I had an issue with the PID file in the SonarQube home directory. The PID file is created, but it is called sonar.pid, and the Systemd service file is looking for SonarQube.pid. SonarQube does start and works, for a short time, but then Systemd times out because it can't find the PID file, and it then terminates SonarQube.

This PR adds a pidfile parameter defaulting to "SonarQube.pid" (which is currently the fixed filename), making us able to configure which PIDFile that Systemd should use if there is a mismatch.

fraenki commented 2 years ago

Merged, thanks!

PS: The "stealth" LDAP change would have been better suited in a new PR. I've merged it anyway, but overall using one PR for every contribution (and not mixing multiple topics in a PR) makes review much easier. :)