markteekman / accessible-astro-starter

An Accessible Starter Theme for Astro 4.0 including accessibility features such as landmarks, better focus-outline and skip-links navigation. Ships with Tailwind, Prettier and ESLint support.

https://accessible-astro.netlify.app/

MIT License

758 stars 139 forks source link

Sub Menu Z-Index on Desktop #46

Closed yohuck closed 2 years ago

yohuck commented 2 years ago

The sub menu z-index is set to 0 on desktop so it doesn't inherit the menu z-index of 100 and displays underneath components like the cards.

In the chrome developer tools it can be debugged by switching off the z-index: 0:

main-navigation.is-desktop .desktop-menu {

visibility: visible;
z-index: 0;
position: static;

}

Untitled_ Nov 4, 2022 11_17 PM

markteekman commented 2 years ago

Good one @yohuck! Hadn't spotted it yet 🤔 Thanks for submitting!

yohuck commented 2 years ago

@markteekman I'm happy to work it if you'd like!

markteekman commented 2 years ago

Sure @yohuck! I appreciate the help 😊

yohuck commented 2 years ago

@markteekman made PR https://github.com/markteekman/accessible-astro-starter/pull/47. LMK if you need anything else!

markteekman commented 2 years ago

Thanks a lot @yohuck! Merged and updated the release, thanks for your help. Let me know if you find anything else 🙂