search

markteekman / accessible-astro-starter

An Accessible Starter Theme for Astro 4.0 including accessibility features such as landmarks, better focus-outline and skip-links navigation. Ships with Tailwind, Prettier and ESLint support.
https://accessible-astro.netlify.app/
MIT License
758 stars 139 forks source link

Remove Typescript errors from Navigation.astro #55

Closed shawninder closed 1 year ago

shawninder commented 1 year ago

The code worked and still works, but now there are fewer Typescript errors highlighted. There is still one left, but I'm not yet sure how to fix it.

netlify[bot] commented 1 year ago

Deploy Preview for accessible-astro ready!

Name Link
Latest commit 5db5e253c34b1f19f2b7e90d5c88c9c89253c9e2
Latest deploy log https://app.netlify.com/sites/accessible-astro/deploys/64175dbc00198700083db8fa
Deploy Preview https://deploy-preview-55--accessible-astro.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

markteekman commented 1 year ago

Thanks for this contribution @shawninder! I know TypeScript is a big part of Astro and it's on my todolist. Your PR here is a great step towards that goal, I appreciate it!