search

markteekman / accessible-astro-starter

An Accessible Starter Theme for Astro 4.0 including accessibility features such as landmarks, better focus-outline and skip-links navigation. Ships with Tailwind, Prettier and ESLint support.
https://accessible-astro.netlify.app/
MIT License
758 stars 139 forks source link

Fix the meta title that didn't have the subtitle #65

Closed sakynasty closed 1 year ago

sakynasty commented 1 year ago

Result before fix

<meta content="Home" name="title">

Result after fix

<meta content="Home - MyWebsite" name="title">
netlify[bot] commented 1 year ago

Deploy Preview for accessible-astro failed.

Name Link
Latest commit 03afbfd74129e723b728cc6946eaf07ae1ed6a9d
Latest deploy log https://app.netlify.com/sites/accessible-astro/deploys/64a94ec3f9dcd000089a62d2
markteekman commented 1 year ago

Hey @EndLouvy, thanks for submitting the PR, I appreciated your help! 😊 I see that the Netlify deploy preview fails with the following error: [@mdx-js/rollup] The argument 'path' must be a string or Uint8Array without null bytes. Received '\x00@astro-page:src/pages/mdx-page@_@mdx'.

If I run npm run build locally it doesn't produce an error, so I'll have to dive into this when I've got a little more time.

markteekman commented 1 year ago

@3Leelou I think I have found the issue: https://github.com/withastro/astro/issues/7302. Can you run the following command and update the PR? 🙂

npm remove @astrojs/mdx && npm i -D @astrojs/mdx

Thanks! 😊

sakynasty commented 1 year ago

It's done. https://github.com/markteekman/accessible-astro-starter/pull/67