Modals aren't working in demo

[diomed]

you might wanna check on that, but clicking on buttons to display modals doesnt do anything.

[markteekman]

Hey @diomed, nice catch! Weird, I'll have to look into it. I'll wait for this PR https://github.com/markteekman/accessible-astro-components/pull/57 to resolve and see if it fixes anything.

[jonnywillrees]

I've noticed that the modal buttons still don't open the modal in the live demo of accessible-astro-starter

[jonnywillrees]

Update on the modal buttons not working: I have came to the same conclusion as David mentioned here https://github.com/markteekman/accessible-astro-components/pull/57#issuecomment-1702378704.

Seems the modals work perfectly locally, but not on the live hosted version. Very strange.

[markteekman]

@jonnywillrees you're absolutely right, seems like it is not working once more 🤔 It did still work on this preview with the latest astro-components package update: https://deploy-preview-74--accessible-astro.netlify.app/. I didn't notice before but it seems like the deploy got an error after PR #76 by @saulopaiva with the following log:

7:30:20 PM: build-image version: 73f16e520fdddf409be6f578c8c2c8941bdf32d3 (focal)
7:30:20 PM: buildbot version: a11acbb405af91d225b392f15bc00822dbffb366
7:30:20 PM: Fetching cached dependencies
7:30:20 PM: Starting to download cache of 177.4MB
7:30:24 PM: Finished downloading cache in 3.8s
7:30:24 PM: Starting to extract cache
7:30:26 PM: Finished extracting cache in 2.414s
7:30:26 PM: Finished fetching cache in 6.264s
7:30:26 PM: Starting to prepare the repo for build
7:30:27 PM: Preparing Git Reference refs/heads/main
7:30:28 PM: Starting to install dependencies
7:30:28 PM: Python version set to 3.8
7:30:28 PM: Attempting Ruby version 2.7.2, read from environment
7:30:29 PM: Using Ruby version 2.7.2
7:30:29 PM: Started restoring cached go cache
7:30:29 PM: Finished restoring cached go cache
7:30:29 PM: go version go1.19.12 linux/amd64
7:30:30 PM: Using PHP version 8.0
7:30:31 PM: Started restoring cached Node.js version
7:30:31 PM: Finished restoring cached Node.js version
7:30:31 PM: Attempting Node.js version 'v20.5.1' from .nvmrc
7:30:32 PM: Downloading and installing node v20.5.1...
7:30:32 PM: Downloading https://nodejs.org/dist/v20.5.1/node-v20.5.1-linux-x64.tar.xz...
7:30:32 PM: Computing checksum with sha256sum
7:30:32 PM: Checksums matched!
7:30:34 PM: Now using node v20.5.1 (npm v9.8.0)
7:30:35 PM: Enabling Node.js Corepack
7:30:35 PM: Started restoring cached build plugins
7:30:35 PM: Finished restoring cached build plugins
7:30:35 PM: Started restoring cached corepack dependencies
7:30:35 PM: Finished restoring cached corepack dependencies
7:30:35 PM: No npm workspaces detected
7:30:35 PM: Started restoring cached node modules
7:30:35 PM: Finished restoring cached node modules
7:30:35 PM: Installing npm packages using npm version 9.8.0
7:30:38 PM: npm ERR! code ERESOLVE
7:30:38 PM: npm ERR! ERESOLVE could not resolve
7:30:38 PM: npm ERR!
7:30:38 PM: npm ERR! While resolving: accessible-astro-starter@3.0.0
7:30:38 PM: npm ERR! Found: @astrojs/mdx@0.19.7
7:30:38 PM: npm ERR! node_modules/@astrojs/mdx
7:30:38 PM: npm ERR!   dev @astrojs/mdx@^1.0.2 from the root project
7:30:38 PM: npm ERR!
7:30:38 PM: npm ERR! Could not resolve dependency:
7:30:38 PM: npm ERR! dev @astrojs/mdx@^1.0.2 from the root project
7:30:38 PM: npm ERR!
7:30:38 PM: npm ERR! Conflicting peer dependency: astro@3.0.12
7:30:38 PM: npm ERR! node_modules/astro
7:30:38 PM: npm ERR!   peer astro@^3.0.11 from @astrojs/mdx@1.0.3
7:30:38 PM: npm ERR!   node_modules/@astrojs/mdx
7:30:38 PM: npm ERR!     dev @astrojs/mdx@^1.0.2 from the root project
7:30:38 PM: npm ERR!
7:30:38 PM: npm ERR! Fix the upstream dependency conflict, or retry
7:30:38 PM: npm ERR! this command with --force or --legacy-peer-deps
7:30:38 PM: npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
7:30:38 PM: npm ERR!
7:30:38 PM: npm ERR!
7:30:38 PM: npm ERR! For a full report see:
7:30:38 PM: npm ERR! /opt/buildhome/.npm/_logs/2023-09-09T17_30_35_533Z-eresolve-report.txt
7:30:38 PM: npm ERR! A complete log of this run can be found in: /opt/buildhome/.npm/_logs/2023-09-09T17_30_35_533Z-debug-0.log
7:30:38 PM: Error during npm install
7:30:38 PM: Build was terminated: dependency_installation script returned non-zero exit code: 1
7:30:38 PM: Failing build: Failed to install dependencies
7:30:38 PM: Finished processing build request in 17.78s

I'll reopen this issue and add another for the deploy fail, thanks for taking notice @jonnywillrees!

[saulopaiva]

Hi, everyone.

I'll try to have a look too. But it's really wierd cause this is occourring only on the accessible-astro-starter domain.

I mounted this environment in the PR #76 for tests: https://feature-upgrade-astro-to-3--lustrous-bublanina-6b164e.netlify.app/

Thanks for the reporting!

[markteekman]

Thanks @saulopaiva! Seems really specific to the accessible starter domain indeed, since it's working fine on your end. I'll dive into it when I've got more time, double checking the settings on Netlify for this project. Thanks for lending a hand!

[markteekman]

@jonnywillrees @saulopaiva it's fixed again thanks to @david-abell's suggestion to run another build whilst clearing the cache: https://github.com/markteekman/accessible-astro-starter/issues/78. There is still a small issue to the modals height in Safari, but I'll address that in the other repo.

Thanks everyone!