Closed danbars closed 4 years ago
Thanks for the PR! The existing cors-header is very simplistic and I'm not certain exactly how it should work :) I'll ask questions in code comments to make sure I understand.
I'm going to commit the changes. Let me know if you think it's better
Looks good. Looks like the test for the cors handler needs to be updated and there might be some minor lint fixes. Could you check that the tests pass locally? Thanks!!
I will try to work on the tests and lint tomorrow.
Think it looks good now, just needs the test to pass. Let me know if you want me to help out.
Hi, sorry, I didn't get to it yet. I hope to get to it tomorrow.
Hi @markusahlstrand, finally got to complete this, sorry about the long delay. Lint and tests all pass + added new tests Also updated the readme with the new configuration.
Nice! Just waiting for the travis build to go through..
Merged, thanks for the PR!
Great, thanks for the project ;-)
Origin
header that can be sent in different non CORS events too. It is identified byOPTIONS
method andAccess-Control-Request-Method
headerAccess-Control-*
headers using options.If you like these changes I can also update the docs.