Release EXE requires JRE to run

markusaksli / TradeBot

Crypto trading bot using Binance API (Java)

GNU General Public License v3.0

385 stars 138 forks source link

Release EXE requires JRE to run #11

Closed RichyHBM closed 3 years ago

RichyHBM commented 3 years ago

Describe the bug As per the title, the current EXE doesn't run when the JRE is not present, further more I have installed Java 11 JDK and it doesnt recognise that either (though that may be my system/java setup)

To Reproduce Steps to reproduce the behavior: Download EXE Run Tradebot.exe Program prints "TradeBot: This application requires a Java Runtime Environment 1.8 - 12"

Logs TradeBot: This application requires a Java Runtime Environment 1.8 - 12

Desktop:

OS: Windows 10

markusaksli commented 3 years ago

I was a bit confused as to how launch4j includes the bundled JRE but the latest version https://github.com/markusaksli/TradeBot/releases/tag/v0.8.2 should fix this.

It now includes a proper stripped JRE made from JDK 11 with jlink and the proper path to it in the exe.

Let me know if it doesn't work for you.