markusbonse / applefy

A Python package for calculating detection limits for exoplanet high contrast imaging (HCI) datasets.
https://applefy.readthedocs.io/
MIT License
5 stars 4 forks source link

Applefy ASDI #6

Open lwelzel opened 12 months ago

lwelzel commented 12 months ago

Hi Markus,

I would like to use applefy to characterize the performance of a HCI data reduction algorithm. While I understand that applefy currently only supports ADI cubes out of the box, I would like to know if there is a way to extend this package to also handle full ASDI cubes (and 3D PSF template) to determine contrast curves and/or grids for a data reduction algorithm. Any advice on similar packages that support ASDI cubes would also be appreciated.

Thanks for the great package!

markusbonse commented 11 months ago

Hi Lukas,

at the moment there is no support for ASDI data in applefy. However, it should be possible to extend the current code without rewriting the whole package. If you have the time to implement these features it would be great! Feel free to create a pull request and I'll review your changes.

In order to extend applefy for ASDI data you need to extend / modify the Contrast class. It is the main capsule for all fake planet experiments and data handling. To do so inherit from it and change the functions needed to insert the fake planets.

Those probably include:

The statistical tests as well as the post-processing algorithms are separate from the calculation of the contrast grids and contrast curves. If you manage to implement your changes within the current package structure you should be able to use these features without further modifications. I hope this helps!

Markus

lwelzel commented 11 months ago

Hi Markus,

Thank you for your advice on the required changes to support ASDI data, I will get back to you if I have a working implementation.