search

markusenglund / react-kanban

A Trello-like application built with React and Redux. Take a look at the live website:
https://www.reactkanban.com
MIT License
1.73k stars 245 forks source link

Add .env boolean variables to disable login options. #7

Open 0x0f0f0f opened 6 years ago

0x0f0f0f commented 6 years ago

It would be really useful to add these optional env variables to disable/enable certain login options.

ENABLE_GUEST_LOGIN=false # Set to true by default
ENABLE_GOOGLE_LOGIN=false # Set to true by default
ENABLE_TWITTER_LOGIN=false # Set to true by default

The app should crash if no login options are enabled, and the app should ignore the API keys and secrets variables if that login option is disabled

markusenglund commented 6 years ago

I don't really understand what this does. Could you explain a bit more why this would be useful?

0x0f0f0f commented 6 years ago

Let's say some of my coworkers use Google and don't have any Twitter account or viceversa, I shouldn't have to register an API key in the app 😄. On a local server with limited resources (such as my Raspberry Pi) it would also be useful to deny guest users to sign up and use valuable disk space

markusenglund commented 6 years ago

Ok, makes sense. If you want to make a PR I'll merge it.