Additional Props: backgroundBorderStyle, disableBackground

[mgrubinger]

Hi!

Thanks for creating this cool react switch!

I was missing the possibility to create an "outline"-style switch using the available props. Like this:

I added two props to make this possible:

• backgroundBorderStyle: define the style of the border of the background, like 2px solid #000 ( the color is not really necessary, as it will use the colors from onColor / offColor )

• disableBackground: set this to true to get a transparent background for the switch.

I also updated the README.md to reflect those two new props.

Let me know what you thing or if anything is missing.

Thanks, -Martin

[markusenglund]

Hi,

I like that look for the component, but I have some concerns about the implementation.

1. I want to keep the public API as small and simple as possible, since more props adds confusion for library users and everything that's added has to be basically supported forever. Adding two new props can be ok, but since they're not really useful for anything other than this use case I'm hesitant.
2. By setting the background to 'border-box' we break the positioning of the icons inside the switch.

Overall I feel like this adds more overhead than it's worth.

[mgrubinger]

Hi!

Thanks for your answer and explanation. I understand your point, and I realized I can do most of this using css anyway. :)