search

markusfisch / BinaryEye

Yet another barcode scanner for Android
https://play.google.com/store/apps/details?id=de.markusfisch.android.binaryeye
MIT License
1.5k stars 122 forks source link

WPA2-EAP: attribute "Anonymous Identity" not transferred over into the WiFi profile #231

Closed JacobKochems closed 3 years ago

JacobKochems commented 3 years ago

Hello, I installed the app version 1.45.0 within Android 8.1 and created a QR code with the tool qrencode with the following content:

WIFI:T:WPA2-EAP;S:my-wifi;P:5abpa8mrwjmr35in;E:PEAP;I:ident;A:anonymous;PH2:MSCHAPV2;;

When I scan it with Binary Eye the correct string gets displayed and the button to add a WiFi profile appears. After hitting that button it seems that the key-value pair A:anonymous is ignored or "gets lost" somehow since the corresponding field in the WiFi connection profile form is empty. The other fields/attributes are correct.

Thanks for this app by the way, it works great otherwise.

markusfisch commented 3 years ago

Ah, yes, sorry for the inconvenience 🙈 Binary Eye supports only "AI:" instead of "A:" for the Anonymous Identity at the moment 😬

I'll add support for "A:" with the next version. Thank you for reporting this 👍

markusfisch commented 3 years ago

Implemented in https://github.com/markusfisch/BinaryEye/commit/867f179a371854c07711efd34051c6ac22efedcb

JacobKochems commented 3 years ago

Hello @markusfisch, you're welcome and thank you for your response. I see you have it already implemented. I'm curious, isn't this functionality already a part of the zxing library? If so, did you implement it yourself to workaround certain limitations? Because with the Barcode Scanner app from zxing this attribute gets through but some other doesn't.

markusfisch commented 3 years ago

No, this isn't part of the ZXing barcode scanning library, but of the accompanying (and abandoned) Android app. So it's part of the repo but not of the library.

The implementation in Binary Eye was a contribution of @molikuner, and it was re-implemented because Binary Eye is written in Kotlin while the Android app of ZXing was written in Java.