search

markusfisch / BinaryEye

Yet another barcode scanner for Android
https://play.google.com/store/apps/details?id=de.markusfisch.android.binaryeye
MIT License
1.43k stars 117 forks source link

MATMSG e-mails are processed as text instead of e-mail #265

Closed travelalpaca closed 2 years ago

travelalpaca commented 2 years ago

BinaryEye correctly handles mailto format as e-mail, but it fails to handle MATMSG format as e-mail.

Example of mailto format from here:

mailto:hola@2amigos.us

Example of MATMSG format from here:

MATMSG:TO:support@morovia.com;SUB:QRCode Generator;BODY:you guys are doing a great job!;;

Other resources on MATMSG:

markusfisch commented 2 years ago

Yes, unfortunately, MATMSG isn't supported yet. Thanks for pointing this out! 👍 Somehow I haven't come into contact with it yet.

I will add support for MATMSG with the next release.

markusfisch commented 2 years ago

Implemented in https://github.com/markusfisch/BinaryEye/commit/57fea95b9b6e9092b74da1aba15e682a535e843d

travelalpaca commented 2 years ago

I see that this was implemented in Version 1.50.0, however I don't think it's working correctly. I am testing the MATMSG example, and while Binary Eye now does call up the e-mail app, it doesn't fill out all the fields correctly. I tested on a couple devices and a couple e-mail apps, and in no case was the To address filled out, and it was inconsistent whether the Subject or Body was filled out.

I also tested the ZXing scanner https://f-droid.org/en/packages/com.google.zxing.client.android/ and it successfully handles MATMSG in all the cases I tested.

markusfisch commented 2 years ago

You're right, sorry! The TO: address was incorrectly transferred. Fixed in 75a59b

But I don't understand why Subject or Body isn't reliably filled out 🤔 Can it be that SUB:/BODY: isn't all upper-case in some of these samples? Or is MATMSG: missing?

Would you mind sharing some of the samples that do not work?

travelalpaca commented 2 years ago

The Subject and Body do already work for Gmail app, for example. So if 75a59b fixes the To address, then I'd guess it's fine.

I'm looking more into the e-mail app that isn't accepting Subject or Body, and I'm realizing that this specific e-mail app is probably flawed because if I intentionally mess up the To address it seems to always fail even when using the ZXing scanner. Since it looks like the Subject and Body errors are the fault of this e-mail app that is overly sensitive to the To field being correct in the first place, I bet your recent commit will fix MATMSG completely for the e-mail apps I can test.