search

markusfisch / BinaryEye

Yet another barcode scanner for Android
https://play.google.com/store/apps/details?id=de.markusfisch.android.binaryeye
MIT License
1.43k stars 117 forks source link

add persian translation #291

Closed eshagh79 closed 2 years ago

eshagh79 commented 2 years ago

Hello, I am trying to add Persian language to this program. Probably the Persian translation has some problems that I will find and fix after the new version is released. Thank you for your good program

markusfisch commented 2 years ago

Thanks a lot 👍

eshagh79 commented 2 years ago

I think that in order to be able to select the Farsi language from within the program, it should be added to the app/src/main/res/values/locales.xml file, right?

markusfisch commented 2 years ago

Yes, exactly! I just added it in https://github.com/markusfisch/BinaryEye/commit/2e060d1ca8c65d9be15eeadf44ca250d622d5112 and removed the Persian translation of locales.xml because this listing isn't really meant to be translated 😬 If a user accidentally selects a language they do not speak, it is not easy to undo this if you do not understand the language names 😉