search

markusfisch / BinaryEye

Yet another barcode scanner for Android
https://play.google.com/store/apps/details?id=de.markusfisch.android.binaryeye
MIT License
1.51k stars 121 forks source link

scanning the same barcode twice #336

Open jdohm opened 1 year ago

jdohm commented 1 year ago

If "Scan continuously" is active and "Ignore duplicates" is disabled, I would assume that it would be possible to scan the same code twice in succession. However, scanning the same code again is only possible if a) another action has taken place in between (opening the menu, closing and opening the app, etc) or b) another barcode was scanned in between.

I'm not sure if this is intended behavior, since this reduces the risk of scanning the same code twice by accident (even tho this is also reduced by the delay between scans). I was trying to get the time between two scans to stop timings. I don't think this is an use case that is common. Therefore I think leaving it as is could also be the right decision.

markusfisch commented 1 year ago

Hm, yes, this is confusing indeed 😬

Currently, "Ignore duplicates" applies only to the history database (if it is enabled).

When "Scan continuously" is active, the previously scanned code is always ignored to avoid scanning the same code twice.

But that is clearly in conflict with "Ignore duplicates", so I changed this behaviour (in c5d6bfa4b2bfda6be4167f3be3d0f424fbf3e6d4) to allow duplicates when scanning continousely too.