search

markusfisch / BinaryEye

Yet another barcode scanner for Android
https://play.google.com/store/apps/details?id=de.markusfisch.android.binaryeye
MIT License
1.42k stars 117 forks source link

monochrome icon show error #339

Closed Mystery00 closed 1 year ago

Mystery00 commented 1 year ago

image

Mystery00 commented 1 year ago

The monochrome icon needs to use android:fillAlpha to represent the difference in color

markusfisch commented 1 year ago

Thanks for fixing this right away 👍

tsiflimagas commented 1 year ago

Was this fixed for you? It's still showing like that for me.

Mystery00 commented 1 year ago

Was this fixed for you? It's still showing like that for me.

Maybe the latest version of Google play doesn't include this commit

tsiflimagas commented 1 year ago

I'm on 1.58.0 which should include this commit.

Mystery00 commented 1 year ago

I am also version 1.58.0 and the monochrome icons are not working correctly

markusfisch commented 1 year ago

Sorry, this isn't easy to test, unfortunately. Somehow I can't enable themed icons on my Pixel 7 🤔

What devices are you on?

Mystery00 commented 1 year ago

Sorry, this isn't easy to test, unfortunately. Somehow I can't enable themed icons on my Pixel 7 🤔

What devices are you on?

https://www.androidpolice.com/android-13-themed-icons-how-to-activate/

You can check out this tutorial to enable themed icons on Pixel 7, my device is Pixel 6 pro running Android 13

markusfisch commented 1 year ago

Well, I didn't have the "Themed icons" switch on my Pixel 7 Pro 🙈 But I found out it's because I don't use the Pixel launcher (I use my own on all of my devices). Curiously, setting the Pixel launcher as the default launcher, doesn't immediately show the option too 🤷‍♂️

Anyway, I just used the emulator to enable themed icons and was able to debug the issue. I misunderstood how monochrome icons should be designed. This is now fixed in https://github.com/markusfisch/BinaryEye/commit/dfd64405da28d597d9cf02f5f6a4ceaf1cc50180

I will publish a new version soon. Thanks a lot for reporting! 👍

tsiflimagas commented 1 year ago

I made a debug build and I confirm the monochrome icon now looks good. Screenshot_20230130-230956_Arrow Launcher_1.png

Mystery00 commented 1 year ago

I made a debug build and I confirm the monochrome icon now looks good. Screenshot_20230130-230956_Arrow Launcher_1.png

Yep, that's weird why the version distributed by Google play shows the wrong monochrome icon

tsiflimagas commented 1 year ago

Because a866a2e didn't fix it, dfd6440 did, which is not in a release yet.

tsiflimagas commented 1 year ago

I think this can be closed now.