search

markusfisch / BinaryEye

Yet another barcode scanner for Android
https://play.google.com/store/apps/details?id=de.markusfisch.android.binaryeye
MIT License
1.42k stars 117 forks source link

Do not auto-close without camera access #351

Closed NePoCz closed 1 year ago

NePoCz commented 1 year ago

Currently, the app will close when camera access is denied. But it should work perfectly fine for scanning images from gallery even without camera access & you can still generate codes. Why auto-close it, when other functions cas still be used? I understand this is a not a common use case, but not impossible either

markusfisch commented 1 year ago

Yes, that's right!

I will change this with the next version.

markusfisch commented 1 year ago

Fixed in https://github.com/markusfisch/BinaryEye/commit/7dfd7a130320115c291fc1f34dfc137fb74876b7

NePoCz commented 1 year ago

Great, thanks for the fast fix and awesome app. A small question comment though - I didnt see any changes to the toast message as part of the commit. It currently says "This app does not make any sense without camera access. Good bye." which naturally wouldnt make sense any more.

markusfisch commented 1 year ago

You're right! 👍 Removed this message in https://github.com/markusfisch/BinaryEye/commit/a489f3aa22af5163e9ecd0ad60164ccb10eefb56