search

markusfisch / BinaryEye

Yet another barcode scanner for Android
https://play.google.com/store/apps/details?id=de.markusfisch.android.binaryeye
MIT License
1.42k stars 117 forks source link

Incorrect error correction level used when generating QR codes #357

Closed mantas-p closed 1 year ago

mantas-p commented 1 year ago

When QR is generated using L, M or Q EC setting, resulting code has L EC level, with H EC setting code comes out as M. This happen both when generating codes manually, and when code is displayed after scanning. EC level is correctly recognized for scanned code, only regenerated image is incorrect.

markusfisch commented 1 year ago

This is a bug 🙈 Thanks for reporting 👍

Fixed in https://github.com/markusfisch/BinaryEye/commit/24766f55d4e3cd07e835986b87a53a762b0c8834

A new version will become available soon.

mantas-p commented 1 year ago

Thanks for update. Code generated manually is now correct, but one shown after scanning still uses different EC level than what was scanned.

markusfisch commented 1 year ago

You're right! I was thinking about that when I was fixing it but forget this part somehow 🙈 Thanks for reminding me! 👍

Fixed in https://github.com/markusfisch/BinaryEye/commit/b4d66e28e272ed1f6a6c0a6355a26b624dd37ed4