Simplification and clean up of Gradle files

markusfisch / BinaryEye

Yet another barcode scanner for Android

https://play.google.com/store/apps/details?id=de.markusfisch.android.binaryeye

MIT License

1.38k stars 114 forks source link

Simplification and clean up of Gradle files #416

Closed meenbeese closed 8 months ago

meenbeese commented 8 months ago

I tried to clean up our Gradle files a bit by:

Implementing some linting suggestions
Moving some things around for clarity
Replacing deprecated methods with new ones
Transferring all repo declarations to the settings file

P.S. Gradle sync works fine but please test for yourself if the app compiles. I can't test because of a java.lang.UnsatisfiedLinkError: dlopen failed: library "libzxing.so" not found error.

markusfisch commented 8 months ago

Thanks for the contribution! I'm just wondering about what's the rationale behind some of these changes 🤔 Please check my single line comments.

I can't test because of a java.lang.UnsatisfiedLinkError: dlopen failed: library "libzxing.so" not found error.

Did you maybe try to run the app on x86 hardware? libzxing.so is the name of the native library from the zxing-cpp dependency, and until very recently this was available for the arm architecture only. With version 2.2.x (of zxing-cpp), x86 is supported too, so master should run just fine.

meenbeese commented 8 months ago

Did you maybe try to run the app on x86 hardware? libzxing.so is the name of the native library from the zxing-cpp dependency, and until very recently this was available for the arm architecture only. With version 2.2.x (of zxing-cpp), x86 is supported too, so master should run just fine.

Yes, I am building the app on x86 Windows. Yet, I don't have any experience with C/C++ so I don't think I will be able to compile any native libraries on my machine. I looked up zxing-cpp but couldn't find any easy installation instructions.

markusfisch commented 8 months ago

Thanks for the quick response and your patience. If you fix the wrong version number of zxing-cpp (see the single line comment), I will merge it.

meenbeese commented 8 months ago

Thanks for the quick response and your patience. If you fix the wrong version number of zxing-cpp (see the single line comment), I will merge it.

I fixed the wrong version number. Should I also squash my commits, because some projects prefer that? As well, updating the zxing-cpp library fixed my problem and I was able to compile the program. I can confirm that the app works correctly when tested on Pixel 6a API 34.

markusfisch commented 8 months ago

Thanks a again for your work on this! 👍