markusfisch / BinaryEye

Yet another barcode scanner for Android
https://play.google.com/store/apps/details?id=de.markusfisch.android.binaryeye
MIT License
1.42k stars 117 forks source link

Feature Request: Warning if Duplicates Detected #484

Open gerryflux opened 3 weeks ago

gerryflux commented 3 weeks ago

I have been enjoying using Binary Eye for about 2 weeks now. I understand of the Ignore Duplicates and History Feature. Currently when those two features are enabled and a duplicate is detected, it's ignored silently. The request I'm making is a build-up on these two, if there could be a toggle to allow the app to show a warning pop-up with or show some visible feedback when a duplicate is detected. I have tried to make a mock-up of the pop-up below: image Don't mind the sloppy design ;)

markusfisch commented 1 week ago

Sorry for the late response. It would sure be possible to add such a dialog!

Currently there are two settings for ignoring duplicates: The app can ignore duplicates that happen directly after each other or avoid any duplicate in the whole history. I think such a dialog would probably only be useful for the latter option.

Still, I am wondering if a dialog is the best choice here since it would require some user interaction. Which could get annoying, I'm afraid. So maybe a (toast) message would be better if you are just interested in when a duplicate was detected?

gerryflux commented 5 days ago

Sure a toast notification could work. About the annoyance should it otherwise be a dialog box, that can be solved by having additional options in the settings under "Ignore Duplicates" such as:

markusfisch commented 5 days ago

Well, with the existing three possibilties:

This would result in something like this:

Feels a bit like feature creep to me 😉 Of course, the silent/toast/dialog option could be another setting.

gerryflux commented 2 days ago

Sure, that'd be a lot to take in and ruin the simplistic nature of the app: What I'd propose would be a re-organisation of the feature:

  1. Renaming the Feature Ignore Duplicates ❌ Duplicates ✅

Under the Feature, I'd keep these options

I have tried to design a mockup for it to show what I mean: image