markusfisch / BinaryEye

Yet another barcode scanner for Android
https://play.google.com/store/apps/details?id=de.markusfisch.android.binaryeye
MIT License
1.55k stars 121 forks source link

Add arabic localization #497

Closed ahmed-0011 closed 1 month ago

markusfisch commented 1 month ago

Thank you 👍

markusfisch commented 1 month ago

One last thing: Lint complains about missing quantity translations for barcode_info:

image

Can you help me there?

ahmed-0011 commented 1 month ago

Hi @markusfisch,

Please check the new changes for plurals tag in this commit: #498.

I think this covers every plural form in Arabic. So, please check again, and if you get the same linter error, I think it's safe to just ignore it.

Note: I specified the other case instead of many because both of them use the same plural form.

markusfisch commented 1 month ago

FYI: I've just added zero (which might be "باطل"?) and many (copied from other) because Lint was still complaining these were missing.

Please let me know if I did something stupid 😉

ahmed-0011 commented 1 month ago

No, "باطل" is too random and is not the correct way to describe "Zero" :)

Zero shares the same plural form with "few", so I used the same string for it. There is another option to translate it to "Empty", but I think translating it to "0 حروف", which is equivalent to "0 characters," is much better.

markusfisch commented 1 month ago

Ah, thanks for the clarification and for the quick fix 👍

I was almost sure that “باطل” wouldn't be the correct translation 🙈 It's always better to ask a native speaker.

ahmed-0011 commented 1 month ago

I'm looking forward to testing the app with Arabic, and maybe I'll find some localization improvements by interacting with the Arabic interface.

By the way, Arabic is an RTL language, so it's written from right to left. I think Android has good support for RTL languages, but maybe integrating a new language with a unique writing mode is a bit complicated.

I'm available if you have any queries about what the Arabic interface should look like :)