search

markusfisch / PieLauncher

Android home screen launcher that uses a dynamic pie menu instead of tables of icons.
https://play.google.com/store/apps/details?id=de.markusfisch.android.pielauncher
MIT License
336 stars 38 forks source link

On inkpalm eink display, the preferences don't #113

Open frank-murphy opened 4 months ago

frank-murphy commented 4 months ago

Screenshot of EPD105

This is an Android 8 device. When I try to change any preference, the dialog is all white, so it's impossible to see anything. By tapping around, it is possible to change the settings, which works. I was able to change the icon set, for example.

markusfisch commented 4 months ago

Hm, that's surprising! 😳 Thanks for filing an issue! 👍

The problem here seems to be that the text color of the options is not inverted as the headline is. Usually, this dialog should have a dark background with white text on it. Since this styling comes from the system (the app doesn't style the dialog at the moment), and the app is using a default API (AlertDialog.Builder.setItems() here) to set the options (without any styling), I would expect this to happen to other dialogs (using the same API) in other apps as well 🤔

Just out of curiosity: is there a (system) setting to not invert these dialogs maybe?

Since I don't have an InkPalm, it's not too easy to find a solution for this, unfortunately.

frank-murphy commented 3 months ago

Do you think you could post a screenshot of what this is supposed to look like? I'm trying to investigate what's going on on my device.

markusfisch commented 3 months ago

Sure, this is the same screen (albeit in german) from the eink display of a Yotaphone 2:

Screenshot_20240606-093441

It's a lot dimmer than what you see. Is it possible that High Contrast mode (may be in Settings > Accessibility > Display size and text or Visibility enhancements) is enabled on the InkPalm? 🤔

frank-murphy commented 3 months ago

Thanks. There is no Hi Contrast mode in Android 8.1 (Oreo), it seems. But I think you're right that it has something to do with theming. You see that the background of your dialog box is grey, but mine is white, then the "Orientation" text is black and centered, while the "Ausrichtung" text is white and left-aligned.

I bet the "Portrait", "Landscape", and "Auto" text is also white and left-aligned on my screen which is why I can't see it. ... Ah. I think I found it. I changed the values-v21/styles.xml to specifically have "Light" there and it works great

frank-murphy commented 3 months ago

Adding a "Dark Mode" option that would follow the system, or override to Dark or Light would be cool. I see that with other apps, like Material Files.