search

markusfisch / PieLauncher

Android home screen launcher that uses a dynamic pie menu instead of tables of icons.
https://play.google.com/store/apps/details?id=de.markusfisch.android.pielauncher
MIT License
336 stars 38 forks source link

Make parent style "Light" #118

Open frank-murphy opened 3 months ago

frank-murphy commented 3 months ago

This makes the AlertDialogs on Oreo readable. (Before, there could be white text on white background.)

markusfisch commented 3 months ago

Well, that would change the theme for Android versions > 13 and < 31 to Light while keeping others at Dark 😬 Of course, we could change to a Light theme on all Android versions, but the bigger issue is that this would be quite a change for everyone. Suddenly, all dialogs become black on white.

I think it's really interesting that Light works on your device and the default, Dark, doesn't 🤔 I would really like to understand why.

Otherwise, just switching to a Light theme might easily break something for someone else 🙈 So I need to run some tests and make sure this doesn't break anything, and this is indeed the only way to make the dialogs work on your device.

frank-murphy commented 3 months ago

Yes, that's totally fair. It does seem that there's a problem with how the themes are defined or used or what the fallback is. I don't know much about how this is supposed to work, but I see in other F-Droid apps some different ways this is done. I found the Theme.Material.Light.NoActionBar in EInkBro, for example. Looking at Librera Reader, I see that it sets a theme by setTheme(R.style.StyledIndicatorsBlack); but I don't see any setTheme(R.style.HomeTheme); in Pie Launcher.

I do see where Pie Launcher sets text_color to #fff (which seems to get converted to #ffffffff) in colors.xml. I bet that is where the white text is coming from, but as I said, I don't really know.