markusfisch
commented
1 year ago Thank you very much for this! And sorry for the late answer - I'm still considering merging it. I'm only hesitating because I'm also not too sure about that extra button on this screen 😬
I was planning to add an extra Activity for the settings, as there are quite some requests for other settings too. Another consideration is that five buttons are too much for narrow screens. So I was thinking about a redesign of the button bar that would allow for a settings button, but without having five buttons in a row.
I will try a few things and then decide which way to go, but I really appreciate your PR and I may still merge it, even if will go in another direction.
A fix suggestion for issue #34 Added a "Change Orientation" button in the pie edit menu. This button changes the orientation and remembers it for future startups.
Design
My first iteration on the concept was a list of buttons, each representing a different orientation, which the user will be able to choose from (perhaps including auto-rotate and locked).
After implementing this however, I noticed that I only ever had use for one of the buttons - the one to change my current orientation. Since the user can infer what their orientation is, and so there's no need to display it, I opted for this simpler one-button design.
I am not 100% fixed on this design, specifically because it changes the configuration menu's purpose (The previous purpose was simply to modify the pie menu, and it was tailored for it). I couldn't think of a different place to put the button that wouldn't hurt the app's simplistic UI, but would love to change it if you have any suggestions.