"Auto start perfect matches" only launches on the next text change - Githubissues

markusfisch / PieLauncher

Android home screen launcher that uses a dynamic pie menu instead of tables of icons.

https://play.google.com/store/apps/details?id=de.markusfisch.android.pielauncher

MIT License

336 stars 38 forks source link

"Auto start perfect matches" only launches on the next text change #86

Closed einmeterhecht closed 7 months ago

einmeterhecht commented 7 months ago

Newly introduced in version 1.17.4

Steps to reproduce:

Turn on "Auto start perfect matches" in the settings
Open the app list
Start typing the name of an app, until it is the only app that shows up

Expected behaviour:

App should be launched automatically Observed behaviour:
App is only launched when the next character is typed

Reason: updateAppList() is only called after the check if only one app matches the query This has changed in 1.17.4 - See HomeActivity in https://github.com/markusfisch/PieLauncher/commit/9fd7110c044762752bb5591115fc4585e59dc041

Potential Fix:

Move updateAppList(); before the if (endsWithDoubleSpace ||... condition: https://github.com/markusfisch/PieLauncher/blob/4a2bc5562c38ba85ec2dc1ab634ad29465410b17/app/src/main/java/de/markusfisch/android/pielauncher/activity/HomeActivity.java#L215-L220

markusfisch commented 7 months ago

Ah, sorry for messing this up 🙈

Fixed in https://github.com/markusfisch/PieLauncher/commit/76dca68227181cf7c3986ba0ec41c2e95c4ef2d9