search

markusfisch / WaveLinesWallpaper

A simple, unobstrusive live wallpaper for Android showing slowly moving wave lines
https://play.google.com/store/apps/details?id=de.markusfisch.android.wavelines
MIT License
104 stars 14 forks source link

Codestyle consistency and tiny cleanup #6

Closed TacoTheDank closed 5 years ago

TacoTheDank commented 5 years ago
markusfisch commented 5 years ago

Thanks a lot! There are quite some typos I wasn't aware about 🙈

The .editorconfig and all of the XML changes are great and I can't wait to merge them.

I just have some questions about some of the changes in the Java files. First, what do you sort the methods by? I noticed you reordered some methods but I don't understand on what principle yet.

To explain my line of thinking; I use to order members and methods by their visibility. Public members come first because when I read the file, I want to know what a class provides from the outside first. Then protected, then private. I also group members after static and final modifiers to make those modifications stand out.

I'd love to hear what principle you're using.

Secondly, I noticed Ctrl+Alt+L did align method call arguments when multiline. With spaces - although .editorconfig specified tabs 🙈 This is a bug in IntelliJ what happily mixes tabs with spaces as if anybody would ever want that 😉 I guess it's just what I get for indenting with tabs in a Java/Android project but I just can't help it 🤷‍♂ IntelliJ's auto formatter could definitely use some love on this but since the bug persists for some time now, I don't think they care much.

markusfisch commented 5 years ago

Partially merged in https://github.com/markusfisch/WaveLinesWallpaper/commit/64c4451d4cabe4b1e8efb72f77d717d783699622

TacoTheDank commented 5 years ago

Actually, the sorting was done automatically from the adjustment of the code to the .editorconfig lol. I don't really go by a specific principle. I like your principle though, it's fairly interesting and is a pretty good idea for code sorting.