search

markushedvall / plantuml-encoder

PlantUML encoder, works in browser & node.js
MIT License
106 stars 15 forks source link

master #2

Closed nrekretep closed 8 years ago

nrekretep commented 8 years ago

Fix for the pako require statement.

markushedvall commented 8 years ago

Unfortunately I can't merge this PR. I don't want to require the whole pako module as that will make the script size a lot bigger. I've limited it to only use the deflate part. However, it is possible to require specific files relative to a package like: require('pako/lib/deflate.js') (https://nodejs.org/api/modules.html#modules_loading_from_node_modules_folders).

I've fixed this in 101d27c

Still, thanks a lot for bringing this to my attention!

nrekretep commented 8 years ago

Thanks for fixing this ;-)