search

markuslerner / THREE.Interactive

Fast and simple interaction manager for three.js for enabling mouse and touch events on 3D objects
MIT License
178 stars 26 forks source link

Prevent pointermove/mousemove events on the body element #4

Closed LucusWebsites closed 2 years ago

LucusWebsites commented 2 years ago

First of all thanks for this awesome lib, really helpfull in a project I am working on.

And it seems that the InteractionManager also binds mousemove/pointermove events to the body element:

https://github.com/markuslerner/THREE.Interactive/blob/d02c1c54fa8126d97c3302eb33f7f4cd809b80d7/src/index.js#L47

In my situation I show a popup when someone clicks something in the 3D scene. But hover events are still fired when someone moves his mouse in the popup.

A simple option to prevent the event binding to the body would be great.

LucusWebsites commented 2 years ago

Also: I can add this function and open a pull request if you want?

markuslerner commented 2 years ago

Hi Edwin,

yes, sure that would be great! Thank you.

I know these events can be very tricky to handle depending on platform, browser and use case.

Best Markus

Am 25.02.2022 um 09:16 schrieb Edwin Bos @.***>:

 Also: I can add this function and open a pull request if you want?

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you are subscribed to this thread.

markuslerner commented 2 years ago

Parameter dontBindEventsOnBody added in release v1.2.1.