search

markusressel / py-image-dedup

CLI utility to find near duplicate images and remove all but the best copy.
GNU Affero General Public License v3.0
156 stars 16 forks source link

numpy warnings suppression is not supported #376

Open puddleoasis opened 3 months ago

puddleoasis commented 3 months ago

Describe the bug

The project uses numpy = "1.24.4". As of numpy=1.24.0, numpy.warnings has been removed. When running from the docker-config.yaml, the image kept crashing until I commented out numpy.warnings.filterwarnings('ignore') in deduplicator.py.

To Reproduce Steps to reproduce the behavior: docker-compose up. The py_image_dedup crashes for me. My logs:

2024-05-28 20:16:56 Starting daemon...
2024-05-28 20:16:56 DEBUG:py_image_dedup.util:Starting daemon...
2024-05-28 20:16:58 Traceback (most recent call last):
2024-05-28 20:16:58   File "/usr/local/bin/py-image-dedup", line 6, in <module>
2024-05-28 20:16:58     sys.exit(cli())
2024-05-28 20:16:58   File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1157, in __call__
2024-05-28 20:16:58     return self.main(*args, **kwargs)
2024-05-28 20:16:58   File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1078, in main
2024-05-28 20:16:58     rv = self.invoke(ctx)
2024-05-28 20:16:58   File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
2024-05-28 20:16:58     return _process_result(sub_ctx.command.invoke(sub_ctx))
2024-05-28 20:16:58   File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
2024-05-28 20:16:58     return ctx.invoke(self.callback, **ctx.params)
2024-05-28 20:16:58   File "/usr/local/lib/python3.10/site-packages/click/core.py", line 783, in invoke
2024-05-28 20:16:58     return __callback(*args, **kwargs)
2024-05-28 20:16:58   File "/app/py_image_dedup/cli.py", line 83, in c_daemon
2024-05-28 20:16:58     deduplicator.deduplicate_all()
2024-05-28 20:16:58   File "/app/py_image_dedup/library/deduplicator.py", line 83, in deduplicate_all
2024-05-28 20:16:58     numpy.warnings.filterwarnings('ignore')
2024-05-28 20:16:58   File "/usr/local/lib/python3.10/site-packages/numpy/__init__.py", line 320, in __getattr__
2024-05-28 20:16:58     raise AttributeError("module {!r} has no attribute "
2024-05-28 20:16:58 AttributeError: module 'numpy' has no attribute 'warnings'. Did you mean: 'hanning'?`

Expected behavior The container to run.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

markusressel commented 3 months ago

Hi @puddleoasis , thx for the report. Should be fixed in 9567b10 , please try again with the latest docker image.