search

markusressel / zfs-inplace-rebalancing

Simple bash script to rebalance pool data between all mirrors when adding vdevs to a pool.
Creative Commons Zero v1.0 Universal
340 stars 30 forks source link

Pointer to resume script if SSH connection times out #11

Closed smaniktahla closed 1 year ago

smaniktahla commented 2 years ago

I've never gotten the job to complete because if my SSH connection times out in putty or my PC sleeps, when I resume, the script starts from the beginning of the file list, even though it doesn't reprocess the files it's already rebalanced.

I'd like to request an enhancement, which is an option to write a flag for each file that's moved and then have the script resume from that point, rather than starting from the beginning. I realize that doing so would break rebalancing for multiple passes, which is why I suggest it be an option to enable.

rattkin commented 1 year ago

you can use standard linux tools made for this, for example tmux, screen etc.

markusressel commented 1 year ago

Hey @smaniktahla, sorry to hear that you encounter issues :disappointed:

As @rattkin mentioned there are better ways to handle an interrupted SSH session from killing the script. I don't think its worth it to add additional complexity to the script just for this edge case. If I didn't write this script in bash but used a programming language the story might be different, but I really don' want to spend more time with bash than I absolutely have to :smile:

smaniktahla commented 1 year ago

Understood. I wasn't aware of those tools until someone on Reddit mentioned tmux, so feel free to close this issue.