search

markusressel / zfs-inplace-rebalancing

Simple bash script to rebalance pool data between all mirrors when adding vdevs to a pool.
Creative Commons Zero v1.0 Universal
340 stars 30 forks source link

Filenames with square brackets are not checked for skipping #6

Closed JosiahWhite closed 2 years ago

JosiahWhite commented 3 years ago

In the case that a filename is something like /pool/projects/[2019] cool project/file.txt, it will constantly be rebalanced, even if a prior run had balanced it. This rebalancing will often be done silently, but depending on the filename, it will also print an error from grep relating to an invalid regular expression.

zeus86 commented 2 years ago

I can confirm this, this happens also to me on a (as of now) recent (TrueNAS-12.0-U8) truenas-instance while rebalancing.

zeus86 commented 2 years ago

To address this, it would be nice, if errors and warnings would have been logged into a seperate logfile to track such things down on longer runs...

markusressel commented 2 years ago

I agree :+1:

markusressel commented 2 years ago

@zeus86 I have added a section about logging to file to the README.

zeus86 commented 2 years ago

awesome :+1: