search

markusritschel / oceanpack

Routines to handle log files of the OceanPack from SubCtech®
https://markusritschel.github.io/oceanpack/
MIT License
0 stars 0 forks source link

In `set_nonoperating_to_nan`, renaming `shift` parameter to `buffer` would make its purpose clearer #2

Open markusritschel opened 3 years ago

markusritschel commented 3 years ago

The shift parameter adds kind of a buffer after each detected non-operating phase. It would make its purpose more intuitive if it's getting renamed.

markusritschel commented 2 years ago

Maybe there's also a more elegant way instead of setting the non-op states to NaN?