markussammallahti / harbour-slackfish

Unoffical Slack client for Sailfish
GNU General Public License v3.0
14 stars 6 forks source link

Message "Slackfish is not responding" every time when open channel #5

Closed Karry closed 6 years ago

Karry commented 7 years ago

There is some long blocking method in UI thread... Do you need help with identify what method it is or it is enough for you?

screenshot_20170228_001

markussammallahti commented 7 years ago

Does this happen every time or randomly? Does this happen with every channel?

Karry commented 7 years ago

It happen every time, with every channel in our team... It tooks around 12 seconds to open channel...

markussammallahti commented 7 years ago

Channel open loads 100 of the latest messages in the channel. It might be that initial 100 takes too long on the UI. I'll see how the initial messages could be loaded in small batches.

Karry commented 7 years ago

It may be the problem. ...or you can just add QTime around critical methods and print elapsed time to stdout... I will send logs then.

ghosalmartin commented 7 years ago

hello, i have same issue, but never managed to make it to the messages, can happily provide debug messages

markussammallahti commented 6 years ago

Latest 1.4 release has performance fixes regarding channel message loading. Can you try with the newest version to see if the fixes solve this issue?

Karry commented 6 years ago

Hi. This problem still exists :-(

Jan 19 11:34:20 Sailfish [29907]: [D] unknown:0 - GET "https://slack.com/api/channels.history?token=xoxp-00000000000-00000000000-000000000000-00000000000000000000000000000000&channel=C0J8HGMAM"
Jan 19 11:34:21 Sailfish [29907]: [D] unknown:0 - Missing emoji "facepalm"
Jan 19 11:34:23 Sailfish lipstick[1096]: [D] onTriggered:98 - Application "Slackfish" with PID 29907 is not responding
Jan 19 11:34:26 Sailfish [29907]: [D] unknown:0 - Missing emoji "simple_smile"
Jan 19 11:34:27 Sailfish [29907]: [D] unknown:0 - Missing emoji "simple_smile"
Jan 19 11:34:27 Sailfish [29907]: [D] unknown:0 - Missing emoji "simple_smile"
Jan 19 11:34:27 Sailfish [29907]: [D] unknown:0 - Missing emoji "simple_smile"
Jan 19 11:34:28 Sailfish [29907]: [D] unknown:0 - Missing emoji "simple_smile"
Jan 19 11:34:28 Sailfish [29907]: [D] unknown:0 - Missing emoji "simple_smile"
Jan 19 11:34:28 Sailfish [29907]: [D] unknown:0 - Missing emoji "simple_smile"
Jan 19 11:34:29 Sailfish [29907]: [D] unknown:0 - Missing emoji "simple_smile"
Jan 19 11:34:29 Sailfish [29907]: [D] unknown:0 - Missing emoji "simple_smile"
Jan 19 11:34:29 Sailfish [29907]: [D] unknown:0 - Missing emoji "simple_smile"
Jan 19 11:34:29 Sailfish [29907]: [D] unknown:0 - Missing emoji "simple_smile"
Jan 19 11:34:29 Sailfish [29907]: [D] unknown:0 - Missing emoji "simple_smile"
Jan 19 11:34:30 Sailfish [29907]: [D] unknown:0 - Missing emoji "simple_smile"
Jan 19 11:34:30 Sailfish [29907]: [D] unknown:0 - Missing emoji "simple_smile"
Jan 19 11:34:30 Sailfish [29907]: [D] unknown:0 - Missing emoji "simple_smile"
Jan 19 11:34:31 Sailfish lipstick[1096]: [D] expression for onPong:108 - Unresponsive application "Slackfish" with PID 29907 has started responding again
Jan 19 11:34:31 Sailfish [29907]: [D] unknown:0 - Got message "{\"type\":\"user_change\" .......... }"
Jan 19 11:34:31 Sailfish [29907]: [D] unknown:0 - Check connection 196
Jan 19 11:34:31 Sailfish [29907]: [D] unknown:0 - Got message "{\"type\":\"pong\",\"reply_to\":196}"
markussammallahti commented 6 years ago

Good to know and those logs are great help. The app is doing cpu heavy operations for the loaded messages and thinks it's stuck.

I can decrease the loaded message count and implement load more function which should resolve this.

markussammallahti commented 6 years ago

Newest version 1.4.1 has performance improvements for channel message loading and pagination.

Can you check if the newest version fixes this issue?

Karry commented 6 years ago

Hi. It is much better with latest release. Loading messages still blocks UI for few seconds (~3s), but it is tolerable and I don't see "not responding" system overlay anymore. I am closing this issue.

Thank you!