markusschwenk / midieditor

Provides an interface to edit, record, and play Midi data
GNU General Public License v3.0
470 stars 69 forks source link

Save does not maintain note start-stop message order #43

Open ToriningenGames opened 5 years ago

ToriningenGames commented 5 years ago

When creating two notes with the same channel, on the same track, where the off tick of one note is the same value as the on tick of the second note, then saving, sometimes the order of the off tick and on tick events switch, leading to one longer note with a zero-length note within upon closing and reopening the file, or playing it in an external editor.

GabrielMiceli commented 5 years ago

This drives me crazy, too. I propose that all note offs (or note ons with velocity 0) should come before all other events that are on that same tick. It also happens with recorded data when there is a note off and note on next to each other (the note off always ended up coming after note on). I verified that MIDIEditor was at fault by using another program that logs MIDI messages, and the data was correct.

Boscop commented 4 years ago

@GabrielMiceli This was also my suspicion, btw, which program did you use to log the midi messages to confirm this?

GabrielMiceli commented 4 years ago

@Boscop - I used Qmidiroute.